-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SWOT image to latest pangeo image #580
Conversation
We should definitely ask them to try out the configurator! That frees us from having to do this kinda work. The configurator needs some work though. #569 will enable automatic deployment for the SWOT (aka meom-ige) hub. After that is merged, this can be merged. Regardless of what happens with the configurator, we should get this merged |
We merged #582 instead, so merging this PR should only trigger a deploy for the |
oh, you caught that @sgibson91. The meom-ige folks used to have a hub under 2i2c.cluster.yaml but we moved it to their own project. Guess we didn't decomission the old cluster! Should definitely be in the other file. |
I did see the low-touch-cluster still going this morning in the GCP web GUI! |
@sgibson91 mmm, so does that mean that this PR is not correct? It would be a different cluster yaml file? |
I think so, I think it should be |
If I understand correctly, the changes in your PR should be applied here And the block you have actually modified should be removed? |
@sgibson91 OK I think the latest commit does this, does that look right? I assume we'll have to manually delete the old cluster? I am not sure how to do this these days though |
Looks right to me, but I'll let @yuvipanda officially sign off on it. We don't need to delete the 2i2c cluster, but we will need to delete the Something like:
But we should do that after this has been successfully deployed and the SWOT folk confirm. |
There might be some other old stuff (other namespaces) in the cluster (in fact I have an internal note to open a ticket about that), it is probably worth checking if there is anything else old (and not used) and deletes it as well... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's open another issue to tackle decomissioning the existing hub fully? Otherwise this is good to go.
I opened #612 |
Great! @choldgraf do you feel comfortable merging (and hence deploying) this and checking out if the new image works? |
OK let's see if this works 🙃 |
cc'ing @yuvipanda so he can confirm that this is how the Pangeo hub image updates should work.
Also - should we suggest that the SWOT team try the configurator?