Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SWOT image to latest pangeo image #580

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Conversation

choldgraf
Copy link
Member

cc'ing @yuvipanda so he can confirm that this is how the Pangeo hub image updates should work.

Also - should we suggest that the SWOT team try the configurator?

@yuvipanda
Copy link
Member

We should definitely ask them to try out the configurator! That frees us from having to do this kinda work. The configurator needs some work though.

#569 will enable automatic deployment for the SWOT (aka meom-ige) hub. After that is merged, this can be merged. Regardless of what happens with the configurator, we should get this merged

@sgibson91
Copy link
Member

sgibson91 commented Aug 6, 2021

We merged #582 instead, so merging this PR should only trigger a deploy for the meom cluster. Actually, this PR is updating the 2i2c.cluster.yaml file. But @yuvipanda you thought it would be meom-ige?

@yuvipanda
Copy link
Member

oh, you caught that @sgibson91. The meom-ige folks used to have a hub under 2i2c.cluster.yaml but we moved it to their own project. Guess we didn't decomission the old cluster!

Should definitely be in the other file.

@sgibson91
Copy link
Member

Guess we didn't decomission the old cluster!

I did see the low-touch-cluster still going this morning in the GCP web GUI!

@choldgraf
Copy link
Member Author

choldgraf commented Aug 6, 2021

@sgibson91 mmm, so does that mean that this PR is not correct? It would be a different cluster yaml file?

@sgibson91
Copy link
Member

@sgibson91 mmm, so does that mean that this PR is not correct? It would be a different cluster yaml file?

I think so, I think it should be meom-ige.cluster.yaml but it also sounds like there's some historical confusion and switching about where this config lives.

@sgibson91
Copy link
Member

If I understand correctly, the changes in your PR should be applied here

https://github.com/2i2c-org/pilot-hubs/blob/d6b109e425885232312e462d15dbcc81bf56ca23/config/hubs/meom-ige.cluster.yaml#L89-L91

And the block you have actually modified should be removed?

@choldgraf
Copy link
Member Author

@sgibson91 OK I think the latest commit does this, does that look right?

I assume we'll have to manually delete the old cluster? I am not sure how to do this these days though

@sgibson91
Copy link
Member

I think the latest commit does this, does that look right?

Looks right to me, but I'll let @yuvipanda officially sign off on it. We don't need to delete the 2i2c cluster, but we will need to delete the grenoble deployment.

Something like:

helm delete grenoble --namespace grenoble
helm delete namespace grenoble

But we should do that after this has been successfully deployed and the SWOT folk confirm.

@damianavila
Copy link
Contributor

but we will need to delete the grenoble deployment.

There might be some other old stuff (other namespaces) in the cluster (in fact I have an internal note to open a ticket about that), it is probably worth checking if there is anything else old (and not used) and deletes it as well...

Copy link
Member

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open another issue to tackle decomissioning the existing hub fully? Otherwise this is good to go.

@sgibson91
Copy link
Member

I opened #612

@yuvipanda
Copy link
Member

Great! @choldgraf do you feel comfortable merging (and hence deploying) this and checking out if the new image works?

@choldgraf choldgraf self-assigned this Aug 17, 2021
@choldgraf
Copy link
Member Author

OK let's see if this works 🙃

@choldgraf choldgraf merged commit 35a830b into master Aug 17, 2021
@choldgraf choldgraf deleted the choldgraf-patch-2 branch August 17, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants