-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a matrix job to deploy our hubs #582
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0d3f6bc
Consolidate workflow file per cluster into a single file
sgibson91 ea3d32c
Remove 'per cluster' workflow files
sgibson91 d81b168
Do not use fail-fast and add comment
sgibson91 b85eee2
Add comment about adding new clusters
sgibson91 9433e16
Style format changes to if statements
sgibson91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| name: Deploy and test hubs | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| paths: | ||
| - deployer/** | ||
| - hub-templates/** | ||
| - requirements.txt | ||
| - dev-requirements.txt | ||
| - config/secrets.yaml | ||
| - config/hubs/** | ||
|
|
||
| jobs: | ||
| deploy: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| # Don't stop other deployments if one fails | ||
| fail-fast: false | ||
| matrix: | ||
| cluster_name: | ||
| # To enable auto-deployments for other clusters, | ||
| # add its name to the list | ||
| - 2i2c | ||
| - cloudbank | ||
| - carbonplan | ||
| - meom-ige | ||
| - pangeo-181919 | ||
|
|
||
| steps: | ||
| - name: Checkout repo | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Check if any of our base files have changed | ||
| uses: dorny/paths-filter@v2 | ||
| id: base_files | ||
| with: | ||
| filters: | | ||
| files: | ||
| - "deployer/**" | ||
| - "hub-templates/**" | ||
| - "requirements.txt" | ||
| - "dev-requirements.txt" | ||
| - "config/secrets.yaml" | ||
|
|
||
| - name: Check which cluster.yaml file has changed (if any) | ||
| uses: dorny/paths-filter@v2 | ||
| id: config_files | ||
| with: | ||
| filters: | | ||
| hub_config: | ||
| - "config/hubs/${{ matrix.cluster_name }}.cluster.yaml" | ||
|
|
||
| - name: Setup gcloud | ||
| if: | | ||
| (steps.base_files.outputs.files == 'true') || | ||
| (steps.config_files.outputs.hub_config == 'true') | ||
| uses: google-github-actions/setup-gcloud@master | ||
| with: | ||
| version: '290.0.1' | ||
| # This is used for KMS only | ||
| project_id: two-eye-two-see | ||
| service_account_key: ${{ secrets.GCP_KMS_DECRYPTOR_KEY }} | ||
| export_default_credentials: true | ||
|
|
||
| - name: Setup helm | ||
| if: | | ||
| (steps.base_files.outputs.files == 'true') || | ||
| (steps.config_files.outputs.hub_config == 'true') | ||
| uses: azure/setup-helm@v1 | ||
|
|
||
| - name: Setup sops | ||
| if: | | ||
| (steps.base_files.outputs.files == 'true') || | ||
| (steps.config_files.outputs.hub_config == 'true') | ||
| uses: mdgreenwald/mozilla-sops-action@v1 | ||
|
|
||
| - name: Deploy ${{ matrix.cluster_name }} | ||
| if: | | ||
| (steps.base_files.outputs.files == 'true') || | ||
| (steps.config_files.outputs.hub_config == 'true') | ||
| uses: ./.github/actions/deploy | ||
| with: | ||
| cluster: ${{ matrix.cluster_name }} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a (probably incorrect) diff to show the kinda thing that I meant. The syntax is probably off but this is just to illustrate the idea. Does this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I understand what you want to do, I just think it muddies the water by adding an extra step to traceback through (if you're debugging), rather than clarifying things 🤷🏻♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh I see - I didn't understand that you were talking about tracebacks. Fair enough - I don't feel strongly on this one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha - sorry to be that person, but I'm now coming around to this suggestion. More from a DRY perspective though so the condition only needs to be updated in one place as the workflow is iterated upon.