-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added palomar cc to config/cloudbank.cluster.yaml #395
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -350,3 +350,38 @@ hubs: | |
| - [email protected] | ||
| - [email protected] | ||
| username_pattern: '^(.+@mills\.edu|yuvipanda@gmail\.com|choldgraf@gmail\.com|georgiana\.dolocan@gmail\.com|aculich@berkeley\.edu|jpercy@berkeley\.edu|deployment-service-check)$' | ||
| - name: palomar | ||
| domain: | ||
| - palomar.cloudbank.2i2c.cloud | ||
| template: basehub | ||
| auth0: | ||
| connection: google-oauth2 | ||
| config: | ||
| jupyterhub: | ||
| homepage: | ||
| templateVars: | ||
| org: | ||
| name: Palomar Community College | ||
| logo_url: https://www2.palomar.edu/pages/guidelines/files/2016/03/webGuide_screened_2-color_light.jpg | ||
| url: https://www2.palomar.edu/ | ||
| designed_by: | ||
| name: 2i2c | ||
| url: https://2i2c.org | ||
| operated_by: | ||
| name: CloudBank | ||
| url: http://cloudbank.org/ | ||
| funded_by: | ||
| name: CloudBank | ||
| url: http://cloudbank.org/ | ||
| hub: | ||
| config: | ||
| Authenticator: | ||
| admin_users: &palomar_admins | ||
| - [email protected] | ||
| - [email protected] | ||
| - [email protected] | ||
| - [email protected] | ||
| - [email protected] | ||
| - [email protected] | ||
| - [email protected] | ||
| username_pattern: '^(.+@palomar\.edu|yuvipanda@gmail\.com|choldgraf@gmail\.com|georgiana\.dolocan@gmail\.com|aculich@berkeley\.edu|sean.smorris@berkeley\.edu|deployment-service-check)$' | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuvipanda could you explain what
username_patternmeans here? This line looks correct comparing it to the previous lines, but it's a bit hard to understand what it is and I don't see it documentedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @GeorgianaElena added it in #208, that PR has some context. Any ideas if we can improve this, or where we can document it, @GeorgianaElena?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at it some more, I think it's a regular expression that permits everyone from
@palomar.edu, but also these explicitly listed addresses otherwise.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an admin should not be allowed? I mean... I was expecting the admins to be excluded from the
username_pattern...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too 👀
This is coming from
jupyterhub. All users need to comply withusername_pattern, including admins. Some code references:username_patternis checked invalidate_uservalidate_useris called no matter the user typeOther thing that I noticed and I think it's related, is about
allowed_users. All the admins, apart from being listed in theadmin_userslist, need to be in this allowed list too otherwise they will be denied access.In my mind, if the user it's an admin, then they should be allowed by default.
(These over-complicates a bit #311 too)
I'm thinking about opening a PR on jupyterhub's side about this, but I would like to know your opinion first, in case my intuition is not right and I'm trying to create an anti-pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jumping in a bit late here.
I did look around at entries for the other hubs in the cloudbank.cluster.yaml file. The username_pattern element was in the mills definition but not in the others. I probably should have checked out whether or not to use what appeared to be the general pattern:
as opposed to the pattern mills is using:
Are we ok here? Or should this change?