Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a matrix job to deploy our clusters #581

Closed
yuvipanda opened this issue Aug 5, 2021 · 2 comments · Fixed by #582
Closed

Use a matrix job to deploy our clusters #581

yuvipanda opened this issue Aug 5, 2021 · 2 comments · Fixed by #582

Comments

@yuvipanda
Copy link
Member

For sure! I was going to suggest using something like this action to set a conditional on the paths changed https://github.com/dorny/paths-filter
So we maintain the same behaviour of not doing a deploy when nothing's changed, but we can consolidate into a single workflow file and new clusters can just be added to the matrix element list.

Originally posted by @sgibson91 in #569 (comment)

@sgibson91
Copy link
Member

The current behaviour is that if any of the below filepaths change, even if a .cluster.yaml file doesn't change, we still deploy right?

https://github.com/2i2c-org/pilot-hubs/blob/845c961b3ee95a9f919a7d4c2086fdc8901baa5a/.github/workflows/deploy-2i2c.yaml#L7-L11

I am testing the workflow over here https://github.com/sgibson91/test-pathfile-conds-gh-actions

@choldgraf
Copy link
Member

This sounds like a great idea to me - would definitely improve our DRY for these deploy auto-actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants