-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have a robust set of authentication methods that can serve different users #276
Comments
\o/ Thanks for filing this, @GeorgianaElena. Multiple authentication methods cause some issues around identity mapping. For example, how would I know that In the meantime, I think it would be very helpful to have at least these two additional auth providers:
We should also investigate how we can restrict access based on group membership via auth0. For example, GitHub organization / team membership, or Google Groups membership. I am not 100% sure how to do this with auth0 :| |
Hey all - I am starting to think that we should define a pipeline around pull requests for new features. A couple of times now we have merged in functionality but I don't see any indication of this in the documentation. (latest I noticed was the ORCID auth) I think this is a practice we will regret very quickly if we don't follow it diligently. Can we define "support a feature" as a combination of "Make the feature possible + document its functionality and how to use it"? So we don't tick-off the boxes in the top-level comment until both of those are accomplished? I am not sure the best way to accomplish this, but maybe a modification to the issue template or adding a PR template? (for now I've just added "document ORCID OAuth" above). What do you think? |
2i2c-org/docs#55 has documentation around ORCID, but is missing SRE style docs on 'how to' do it. We should definitely make sure each authentication method we add is documented. |
Closing this in favor of more specific issues: |
Background
We are using Auth0 to provide authentication for the pilot-hubs. Auth0 can be configured with different connections that users can authenticate with and at the time we're using either Google, GitHub. For JupyterHub to understand this, we're "translating" the auht0 connection setup and configure a GenericOAuthenticator..
In theory we support every provider that Auth0 supports, but we’ve currently only tested
google-oauth2
andgithub
. DifferentGenericOAtuthenticator
config options settings might be needed to support the others.We should however explore whether or not we can allow different authentication methods for a hub based on user needs (relevant issue: #228).
Expected timeline
To the question
can we provide authentication via multiple OAuth providers on the same hub with minimal configuration changes?
, I expect we can come up with ayes
orno
answer in less than 2 weeks.However, if this requires significant changes (like writing our own JupyterHub authenticator that wraps multiple existing OAuthenticators), this might extend over a couple of months.
I suggest keeping this issue opened for about 2 months and update its timeline once we come up with a plan.
Steps to complete this goal
The text was updated successfully, but these errors were encountered: