Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on nodepool labeling conventions #136

Closed
yuvipanda opened this issue Dec 11, 2020 · 1 comment
Closed

Standardize on nodepool labeling conventions #136

yuvipanda opened this issue Dec 11, 2020 · 1 comment
Assignees

Comments

@yuvipanda
Copy link
Member

From @consideRatio in #134 (comment):

The configuration scheduling.corePods.nodeAffinity.matchNodePurpose=require will make all core pods of the jupyterhub chart have a required node affinity toward the node label hub.jupyter.org/node-purpose=core.

By using hub.jupyter.org/pool-name it seems like there is a predefined meaning of that label and can cause some confusion, it isn't having a predefined meaning right? If it is a label with meaning for the 2i2c.org pilot hubs, I think we should name it like 2i2c.org/pool-name instead.

We should investigate either node-purpose or switch to a different namespace.

@consideRatio
Copy link
Member

By using hub.jupyter.org/pool-name it seems like there is a predefined meaning of that label and can cause some confusion, it isn't having a predefined meaning right? If it is a label with meaning for the 2i2c.org pilot hubs, I think we should name it like 2i2c.org/pool-name instead.

The k8s label hub.jupyter.org/pool-name is no longer in use, we are instead referencing the k8s label node.kubernetes.io/instance-type for such purposes I think. We have also stopped using the hub.jupyter.org label prefix for labels we define (#1256).

I'll go for a close here, lets open a new issue if there is some concrete aspect to focus on remaining that I've failed to capture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

No branches or pull requests

2 participants