Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier config: Default config + run once on codebase #299

Open
tony opened this issue Jan 24, 2021 · 0 comments · May be fixed by #301
Open

Prettier config: Default config + run once on codebase #299

tony opened this issue Jan 24, 2021 · 0 comments · May be fixed by #301

Comments

@tony
Copy link
Contributor

tony commented Jan 24, 2021

There's no .prettierrc defined, so when I run formatting, stuff is formatted and it makes the diff very elaborate for only styling purposes.

I think it'd be good to have a config set and run it at least once on the codebase

Trailing commas, lambda function parentheses, newlines after commas (I can't narrow this down to a specific prettier option as of yet)

I have no styling opinion to recommend, but will make a PR to update prettier and run prettier across the codebase so Diffs can be consistent across contributor's systems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant