Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Travel category #8363

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Create Travel category #8363

merged 4 commits into from
Jan 16, 2025

Conversation

Carlgo11
Copy link
Member

@Carlgo11 Carlgo11 commented Jan 11, 2025 •
edited
Loading

Resolves #4799

  • Moved all airlines and hotels to the travel category.
  • Removed flygbra.se as they no longer operate.
  • Added regions to DB (Deutsche Bahn)
  • Moved car rentals to travel category.

@Carlgo11 Carlgo11 added add category Issue/PR adds a category to the repo. multiple sites Issue/PR includes multiple sites. labels Jan 11, 2025
@fletcherdodd
Copy link
Contributor

Might be wise to update the categories list in CONTRIBUTING.md with this PR 🙂

@hkamran80
Copy link
Member

Should we include rental car services in travel or leave them in transport?

@hkamran80
Copy link
Member

For some reason, I thought we had way more rental car entries. The only one I could find was SIXT.

@kmpoppe
Copy link
Member

kmpoppe commented Jan 14, 2025

I believe the last time I thought about adding Europcar there wasn't a category they fit ... But that's been quite some time ago 😄

@hkamran80
Copy link
Member

Side note: the PR validator is failing due to too many subrequests.

@Carlgo11
Copy link
Member Author

Yeah 54 changed files is a lot 😅
I can override it if/when the PR is approved.

@Carlgo11 Carlgo11 merged commit 774db1c into 2factorauth:master Jan 16, 2025
1 of 2 checks passed
@Carlgo11 Carlgo11 deleted the create-travel-category branch January 16, 2025 12:31
@hkamran80 hkamran80 mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkamran80 hkamran80 hkamran80 approved these changes

@fletcherdodd fletcherdodd fletcherdodd approved these changes

Assignees
No one assigned
Labels
add category Issue/PR adds a category to the repo. multiple sites Issue/PR includes multiple sites.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Travel Category
4 participants
@Carlgo11 @fletcherdodd @hkamran80 @kmpoppe