Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6 #7

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix #6 #7

merged 1 commit into from
Oct 24, 2024

Conversation

al1-ce
Copy link
Contributor

@al1-ce al1-ce commented Oct 24, 2024

What

What does this pull request accomplish?

  • Fix config not being applied

How

What code changes were made to accomplish it?

  • Move config setup to lua/octohub/config.lua
  • Move plugin/octohub.lua to lua/octohub/setup_cmd.lua
  • Make it so that any config requests are taken from octohub.config instead of local copies of config

Why

Notes

Might be worth renaming setup_cmd.lua to something more appropriate or moving it's code to either octohub.lua or config.lua

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (not needed as it's just simple move-around)
  • I have made corresponding changes to the documentation (not needed, see above)
  • New and existing unit tests pass locally with my changes

@2KAbhishek
Copy link
Owner

Thanks for taking this on, I will be doing some tweaks on top, appreciate it 🤝

@2KAbhishek 2KAbhishek merged commit a233797 into 2KAbhishek:main Oct 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants