Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example config files have unknown and deprecated options #84

Closed
bandtank opened this issue May 17, 2020 · 1 comment
Closed

Example config files have unknown and deprecated options #84

bandtank opened this issue May 17, 2020 · 1 comment

Comments

@bandtank
Copy link

bandtank commented May 17, 2020

$ python --version
Python 3.8.2

$ python -m venv ~/.virtualenvs/vaping

$ source ~/.virtualenvs/vaping/bin/activate

$ pip install vaping vodka graphsrv 

$ pip freeze
certifi==2020.4.5.1
chardet==3.0.4
click==7.1.2
docutils==0.16
Flask==1.1.2
future==0.18.2
gevent==1.5.0
graphsrv==1.6.1
greenlet==0.4.15
idna==2.9
itsdangerous==1.1.0
Jinja2==2.11.2
lockfile==0.12.2
MarkupSafe==1.1.1
munge==0.6.0
pid==2.2.5
pluginmgr==0.6.0
python-daemon==2.2.4
PyYAML==5.3.1
requests==2.23.0
twentyc.tmpl==0.2.0
urllib3==1.25.9
vaping==1.2.0
vodka==2.3.0
Werkzeug==1.0.1

$ git clone [email protected]:20c/vaping.git ~/vaping

$ cd ~/vaping

$ vaping start --home=examples/standalone_dns/ --debug
...
2020-05-17 07:33:25,941 - vodka - WARNING: [config unknown] 'name is not a known configuration variable and has been ignored'
2020-05-17 07:33:25,941 - vodka - WARNING: [config unknown] 'type is not a known configuration variable and has been ignored'
2020-05-17 07:33:25,942 - vodka - WARNING: [config unknown] 'apps.graphsrv.tmpl_engine is not a known configuration variable and has been ignored'
2020-05-17 07:33:25,945 - vodka - WARNING: [config deprecated] plugins.http.host is being deprecated in version Well be removed in 3.0, it's being replaced by the 'bind' config attribute
2020-05-17 07:33:25,945 - vodka - WARNING: [config deprecated] plugins.http.port is being deprecated in version Will be removed in 3.0, it's being replaced by the 'bind' config attribute
...

There are multiple instances of the words name and type in the config file, so I don't know which ones are correct or incorrect. I'm also not sure if the apps.graphsrv.tmpl line has any effect on the output nor do I know what I should do to fix the warning.

@bandtank bandtank changed the title Example config files have deprecated options Example config files have unknown and deprecated options May 17, 2020
@vegu
Copy link
Contributor

vegu commented May 18, 2020

Thanks for the report

Examples should be updated to use bind for the flask plugin setup

apps.graphsrv.tmpl_engine should be renamed to app.graphsrv.template_engine or removed from the config file. Probably the latter.

The name and type unknown errors actually look like a bug to me as i don't see them in the example's config. Variables names are listed as a path to their location, as they are only name and type they should be at the root level of the config object, which they are not.

Message issue is a vodka issue and tracked there: 20c/vodka#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants