Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fping sometimes emits None messages #138

Closed
vegu opened this issue Oct 5, 2021 · 4 comments · Fixed by #151
Closed

Fping sometimes emits None messages #138

vegu opened this issue Oct 5, 2021 · 4 comments · Fixed by #151
Labels
Milestone

Comments

@vegu
Copy link
Contributor

vegu commented Oct 5, 2021

Likely when a target is unreachable.

Spotted by users when using timeseries db as output target. (see #137)

@vegu vegu added the bug label Oct 5, 2021
@grizz
Copy link
Member

grizz commented Oct 10, 2021

It is when a target is unreachable, I'm not sure what else to emit? Maybe NaN?

@vegu
Copy link
Contributor Author

vegu commented Oct 11, 2021

I was wondering if it should just gap by not emitting anything

@mattlan
Copy link

mattlan commented Oct 13, 2021

Shouldn't the inability to reach a target be considered 100% loss? In lieu of that perhaps just a gap as @vegu mentioned to denote that the pings were not sent/received during that cycle.

@vegu
Copy link
Contributor Author

vegu commented Oct 13, 2021

grizz and i discussed this some more a day or two ago and also arrived at sending a 100% loss message as being the best option.

@vegu vegu added this to the Next release milestone Nov 12, 2021
@vegu vegu mentioned this issue Feb 21, 2022
@vegu vegu closed this as completed in #151 Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants