Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 패키지 순환참조 끊기 #17

Closed
2 tasks done
whxogus215 opened this issue Jul 23, 2024 · 0 comments · Fixed by #24
Closed
2 tasks done

refactor: 패키지 순환참조 끊기 #17

whxogus215 opened this issue Jul 23, 2024 · 0 comments · Fixed by #24

Comments

@whxogus215
Copy link
Contributor

whxogus215 commented Jul 23, 2024

이슈가 필요한 이유
feedback 도메인의 applicationpresentation 사이에 패키지 순환참조가 발생하고 있습니다.

현재 FeedbackCreateRequest DTO는 presentationapplication 에서 쓰이고 있습니다.
그러나 FeedbackCreateRequestpresentation 계층에 있다보니 application 계층의 FeedbackService, FeedbackChatCompletionServicepresentation 패키지를 참조하고 있습니다.

현 상황)
feedback.presentation -> feedback.application
feedback.application -> feedback.presentation

image

이슈를 해결하기 위한 아이디어
FeedbackCreateRequestapplication 계층에서 최종적으로 사용되고 있기 때문에 application 패키지의 dto로 이동시키면 순환 참조를 끊을 수 있을 것 같습니다.

작업 목록

  • FeedbackCreateRequest 패키지 이동
  • FeedbackResultResponse, FeedbackResultResponse 패키지 이동

마감 기간

  • 7/24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 완료
Development

Successfully merging a pull request may close this issue.

1 participant