Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config: Consider NBT tag when item is in multiple categories. #101

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Config: Consider NBT tag when item is in multiple categories. #101

merged 1 commit into from
Aug 24, 2023

Conversation

DreamyLynn
Copy link
Contributor

No description provided.

@DreamyLynn
Copy link
Contributor Author

Note that while I've kept the old overloads for ToolCategoryRegistry.get() in order to not make a breaking change to the API, this does deprecate them and they will lead to unexpected behaviour.

2008Choco
2008Choco requested changes Aug 24, 2023
View reviewed changes
Copy link
Owner

@2008Choco 2008Choco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, you should be able to run ./gradlew check to ensure that Checkstyle likes the formatting :)

veinminer-server/src/main/java/wtf/choco/veinminer/tool/ToolCategoryRegistry.java Outdated Show resolved Hide resolved
veinminer-server/src/main/java/wtf/choco/veinminer/tool/ToolCategoryRegistry.java Outdated Show resolved Hide resolved
veinminer-server/src/main/java/wtf/choco/veinminer/tool/ToolCategoryRegistry.java Outdated Show resolved Hide resolved
veinminer-server/src/main/java/wtf/choco/veinminer/tool/ToolCategoryRegistry.java Show resolved Hide resolved
veinminer-bukkit/src/main/java/wtf/choco/veinminer/listener/BreakBlockListener.java Outdated Show resolved Hide resolved
@DreamyLynn DreamyLynn force-pushed the nbt-tag-checking-behaviour branch from 885d086 to 28b1c9a Compare August 24, 2023 21:21
@DreamyLynn
Copy link
Contributor Author

Should be good now :). Also squashed everything into one commit. IntelliJ really doesn't like the CheckStyle rules 😅 .

@DreamyLynn DreamyLynn requested a review from 2008Choco August 24, 2023 21:26
2008Choco
2008Choco approved these changes Aug 24, 2023
View reviewed changes
Copy link
Owner

@2008Choco 2008Choco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you very much <3 Will ship an update tomorrow

@2008Choco 2008Choco merged commit 39b82aa into 2008Choco:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2008Choco 2008Choco 2008Choco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DreamyLynn @2008Choco