Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak in Connect API Container #64

Open
mega-nick opened this issue Mar 17, 2023 · 4 comments
Open

Memory Leak in Connect API Container #64

mega-nick opened this issue Mar 17, 2023 · 4 comments
Assignees
Labels
bug Something isn't working tracked Issue is tracked in 1Password's internal ticketing system as well.

Comments

@mega-nick
Copy link

Your environment

Chart Version: connect-1.10.0
Image version: 1password/connect-api:1.6.1
Helm Version: 3.11.1
Kubernetes Version: v1.24.9-gke.3200

What happened?

I found that the onepassword-connect pod was using a great deal of memory, specifically the connect-api container. The connect-api container was upgraded to the latest version, 1.6.1, and there still seems to be a pretty obvious memory leak.

Steps to reproduce

Deploy the 1Password Connect Helm chart on Kubernetes
View pod memory metrics within an hour or two

Notes & Logs

image

image

max(container_memory_working_set_bytes{container="connect-api", pod="YOUR-POD-NAME"} / (1024*1024)) by (container)

@baryluk
Copy link

baryluk commented May 16, 2023

Yes, it is leaking A LOT

It is bad:

image

We are sending maybe 5 requests per minute to it. (Mostly continuous, 24/7)

@jillianwilson
Copy link
Collaborator

Thank you for reporting this, I appreciate all the detailed information. I'll share with with the team for further investigation

@jillianwilson jillianwilson added tracked Issue is tracked in 1Password's internal ticketing system as well. bug Something isn't working labels May 26, 2023
@tomjohnburton
Copy link

This is a duplicate of #23
This is crazy that it's still not solved...
What is the point of having open source code if you don't maintain it?

@antoineco
Copy link

The report is for v1.6.1, but as of v1.7.0 this issue still exists, despite the changelog indicating otherwise.

In a very much idle cluster (4 secrets):

leak

@volodymyrZotov volodymyrZotov self-assigned this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracked Issue is tracked in 1Password's internal ticketing system as well.
Projects
None yet
Development

No branches or pull requests

6 participants