Update URLs and columns in top-level election table. #876
Conversation
* Remove total receipts and disbursements links. * Add links to source filings. [Resolves fecgov#873]
| tables.barCurrencyColumn({data: 'cash_on_hand_end_period'}), | ||
| tables.urlColumn('pdf_url', {data: 'document_description', className: 'all', orderable: false}) | ||
| { | ||
| render: function(data, type, row, meta) { |
|
How do people feel about "view source forms" instead of links, that is what we have on the candidate page. We can say something else, but I would like it to be consistent. |
|
I still find that wording a little awkward. Closer, but awkward. |
|
If you're talking about the column header, sounds good. If you're talking about the text in each row, I think we want something shorter, or an icon, since it's going to be repeated for every row--I don't want to repeat "View source forms" 30 times per page. |
|
+1 |
|
What about: "Source reports" for the header and then just "View" for the links? |
|
We have "View source forms" other places on the site, so I'm tempted to say we should keep things consistent and have "Source forms" for the header and "View" for the links. Thoughts? |
|
Source forms / View @noahmanger if you feel strongly about "reports" instead of "forms" we should look at those other places and make them all consistent. |
|
So the term we use to describe them everywhere else is actually "Filings". Should it be "View source filings" everywhere? |
|
I'd be in favor of that....and it makes it clear that you're looking at something that was filed by the candidate or committee, not something generated by the FEC. @emileighoutlaw ? |
|
Yes! I am definitely in favor of consistency. So we're going with Source filings / View ? 👍 |
|
Works for me. @LindsayYoung ? |
|
Works for me. We will want to update #878 too. |
|
Made these changes in a PR to Josh's branch. |
Source forms -> Source filings
Update URLs and columns in top-level election table.
[Resolves #873]
This isn't quite ready for merge. Two outstanding questions:
cc @jenniferthibault @noahmanger