Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

updates URL capitalization #860

Merged
merged 1 commit into from
Oct 20, 2015
Merged

updates URL capitalization #860

merged 1 commit into from
Oct 20, 2015

Conversation

emileighoutlaw
Copy link
Contributor

from fec.gov to FEC.gov

[ci skip]

@@ -45,7 +45,7 @@

<header class="site-header">
<div class="disclaimer">
<span class="disclaimer__left">Looking for <a href="http://www.fec.gov">fec.gov?</a></span>
<span class="disclaimer__left">Looking for <a href="http://www.fec.gov">FEC.gov?</a></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed our content guide now recommends all lowercase urls. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent note. And so glad you're reading our content guide!

We've been using FEC.gov and beta.FEC.gov in our other writings. But you're correct that it isn't aligned with our (well reasoned, well supported)18F style of always using lowercase.

We can switch to lowercase (for consistency), but I think we'll need to change all our references to fec.gov or beta.fec.gov.

@leahbannon — thoughts on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this for now to keep things consistent, and then if we want to make a universal change we can.

noahmanger pushed a commit that referenced this pull request Oct 20, 2015
@noahmanger noahmanger merged commit 6297b48 into develop Oct 20, 2015
@noahmanger noahmanger deleted the capitalization-edit branch October 20, 2015 23:22
@emileighoutlaw
Copy link
Contributor Author

Sounds good. I think this is something we should talk about, and I'm glad
you brought it up.

On Tue, Oct 20, 2015 at 7:22 PM, Noah Manger [email protected]
wrote:

Merged #860 #860.


Reply to this email directly or view it on GitHub
#860 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants