Feature/data explinations #746
Conversation
Added a filing section that links to the page of the record.
Made sure it was sentence case.
- made recipt_date into filing date because it was confusing on the receipts tab - standardized some capitalization
|
Content looks good from my end. |
|
@noahmanger this adds some fine print in the filters. I also specified what date we are looking at in the tables when there are more than one date and for committees, I changed "file date" to "first file date" because I thought it was kind of confusing without the first. I wanted to flag this to your attention because those changes that makes some headings a little longer, and I know space is at a premium. |
| <table> | ||
| <tr> | ||
| <td class="panel__term">Filing date</td> | ||
| <td>{{{ datetime receipt_date }}}</td> |
There was a problem hiding this comment.
should this be filing_date ?
There was a problem hiding this comment.
They use "receipt date" for the day the filing was received by the FEC. But that becomes confusing on the Receipts page, where there is "receipt date" and "contribution receipt date" I thought if we called "receipt date" "filing date" that makes the two dates more clear. I changed it on the disbursements since those tables are similar and if there is a section called receipts, receipt date might be confusing. If you have a better idea of how to make it less confusing we can change it.
| </tr> | ||
| <tr> | ||
| <td class="panel__term">View report page</td> | ||
| <td><a href="{{{ pdf_url }}}" target="_blank">View on fec.gov</a></td> |
There was a problem hiding this comment.
This duplicates the "view original image" link at the top of the panel.
There was a problem hiding this comment.
Well, I am blind. Thanks for spotting that!
A thought on the language, what if it says-- "View report page" instead of "View original image" Does @emileighoutlaw or @noahmanger have strong feelings on this micro copy?
There was a problem hiding this comment.
How about "View original report" ?
There was a problem hiding this comment.
We are showing the page that the record is on, which is handy because the reports can be thousands of pages.
There was a problem hiding this comment.
I like "View report page", but then in the filings panels we'd need it to be "View report". Right now we use "View original image" for both.
I was looking at this and think it might make sense for the link under filing date to link to the full report, just so people can have it. I think we should also identify the report it was filed on by name, so you can see, e.g. April Quarterly 2015.
|
I can style the disclaimers in a separate PR after we merge this. |
|
What do we need to do to get this ready for merge @LindsayYoung @noahmanger? I'd like to get rid of the duplicate pdf links, and it sounds like we may want to change some text, but hopefully we can resolve other issues in separate patches. |
|
Merging and doing additional, small changes sounds good to me. |
fix #736
fix #726