styling the no results message

[noahmanger]

Styles the message that shows up if the zip code isn't found. @emileighoutlaw how doest this language work for you? Made a slight adjustment from @LindsayYoung 's original.

[jmcarp]

The language looks good, but I realized there's a minor issue here: it's possible (although pretty unlikely) for users to see this message even when searching by state and district. Occasionally, we run into missing data (e.g., Virgin Islands 1997-98) and show no results. In those cases, saying we couldn't find results for the specified zip code doesn't make sense.

I'm going to condition the warning text on search state: if the user specified a zip code, we'll warn that we couldn't find results "for this ZIP code"; else, that we couldn't find results "for this location". If we want to update that language or behavior, we can file another patch.

@noahmanger: I'm also going to fix the unit tests on merging. @LindsayYoung added a JS unit test asserting that the expected warning text was added when no results were found, and that test broke when the text changed.

[noahmanger]

Sounds good to me. Thanks.

On Fri, Sep 11, 2015 at 6:52 AM, Joshua Carp [email protected]
wrote:

Merged #628 #628.

—
Reply to this email directly or view it on GitHub
#628 (comment).

Noah Manger
18F http://18f.gsa.gov | Work: 415-696-6146

[emileighoutlaw]

I missed the boat, but wanted to pop on and say anyway that this language has my thumbs up.