Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Feature/pretty filings #465

Merged
merged 1 commit into from
Aug 14, 2015
Merged

Feature/pretty filings #465

merged 1 commit into from
Aug 14, 2015

Conversation

LindsayYoung
Copy link
Contributor

This works for committee pages and filings.

Need to add candidate, the API accepts candidate ID so that should be a minor lift.

@LindsayYoung
Copy link
Contributor Author

This should work better with staging data there are some candidate_ids missing from the dev data.

Here is an example of a candidate that works http://localhost:3000/candidate/S4MD00111?tabs=filings

{
data: 'amendment_indicator',
className: 'min-desktop',
render: function(data, type, row, meta) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is repeated below. How about putting it in another file (maybe helpers.js) and writing a little more concisely:

var amendmentMap = {
  A: 'Amended',
  N: 'New'
};
function(data) {
  return amendmentMap[data] || '';
}

@jmcarp jmcarp merged commit bb78c69 into develop Aug 14, 2015
@jmcarp jmcarp removed the plz-review label Aug 14, 2015
@jmcarp jmcarp deleted the feature/pretty-filings branch October 2, 2015 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants