This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Arrow button on rows for panel #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This UI is to make it easier to understand how to open the table rows to show the details panel. A new table column was used to contain the button so that everything fits within data tables width interface. Additional styles were set from the table scss as its generally safe to ensure these styles for any icon in the table. @noahmanger whats the best way to make the arrows as thick as in the mockup? Right now they are thinner.
| orderable: false, | ||
| render: function(data, type, row, meta) { | ||
| return ''; | ||
| return '<i class="icon ti-angle-right"></icon>'; |
|
Don't worry about the width of the arrows. We'll figure it out later with the other visual updates. |
|
The tests failed in this case because npm failed to download some dependencies: |
|
I can't figure out why, but they only show up if your browser is wide enough:
Maybe something to do with the annoying way datatables sets column widths? |
|
@noahmanger maybe. Do I also have to add a class to ensure they show up on all breakpoints? |
|
Oh, I think the issue is that the width property on line 43 was too small. If I set it at 5%, it's visible on desktop, but not on mobile. If I set it to 10%, it's visible on all, but then takes up too much space. |
|
And also you need to add |
added 2 commits
August 5, 2015 10:22
Trying to get the interface working on all screen sizes by messing with the values.
The problem was that data tables uses absolute px values to calculate the table columns, which means if you set the table to be 50%, it will not work like that. This changes the table so it's contained in a div which is 100% and switches to 50% when the panel is active. From here, we have to ensure data tables hides the columns which are supposed to be hidden for the panel. This is done manually in JS (it can't be done in CSS or data tables won't calculate the other columns correctly). It seems this gets the data tables working on all breakpoints so its split 50/50 with the panel when it's active.
noahmanger
pushed a commit
that referenced
this pull request
Aug 5, 2015
Arrow button on rows for panel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This UI is to make it easier to understand how to open the table
rows to show the details panel. A new table column was used to
contain the button so that everything fits within data tables
width interface. Additional styles were set from the table scss
as its generally safe to ensure these styles for any icon in the
table.
@noahmanger whats the best way to make the arrows as thick as in
the mockup? Right now they are thinner.