This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Add persistent URLs for tab items. #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Resolves fecgov#347]
|
The URLs stay persistent if you refresh, but not if you change the cycle select. The page still defaults to the first tab. |
|
Patch updated. There are additional fixes in #411 that need to be merged for this to work completely correctly. |
| <ul role="tablist"> | ||
| <li role="presentation" class="page-tabs__item"><a role="tab" tabindex="0" aria-controls="panel1" aria-selected="true" href="#section-1">Financial Summary</a></li> | ||
| <li role="presentation" class="page-tabs__item"><a role="tab" tabindex="-1" aria-controls="panel2" href="#section-2">Filings</a></li> | ||
| <ul role="tablist" name="tabs"> |
There was a problem hiding this comment.
name shouldn't be used on <ul> and <li>s . Probably should be data-name= ?
|
@noahmanger thanks, fixed! |
noahmanger
pushed a commit
that referenced
this pull request
Aug 5, 2015
Add persistent URLs for tab items.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Resolves #347]
Note: This patch adds persistent URLs to tabs on the candidate and committee detail pages (e.g.
/committee/C00431445?tab=filings). It does not add URLs for more granular content, such as sub-tabs ("Compare by State", "Compare by Employer"), sort rules, map selections, etc. If we want more granular URLs, we can file additional issues.Pinging @noahmanger for review, @onezerojeremy for thoughts on finer URL control (re.: would users like more granular controls?).