This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Add the styles for the close button #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensure the close panel button on bigger then mobile shows up on the right, with an "X" as "Close". This was from design. Technique uses content selectors to ensure everything can be done through CSS to keep code out of confusing JS.
| @@ -37,6 +37,7 @@ | |||
| background: white; | |||
| margin-top: 3px; | |||
| padding: .65rem 1.5rem; | |||
| text-align: right; | |||
There was a problem hiding this comment.
This is aligning everything on the mobile panel to the right.
Only the nav button should be right aligned and only on large screens. This was an issue brought up by Noah.
|
Looks good. Can you fix conflicts and then I'll merge? |
msecret
pushed a commit
that referenced
this pull request
Aug 4, 2015
Add the styles for the close button
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensure the close panel button on bigger then mobile shows up
on the right, with an "X" as "Close". This was from design.
Technique uses content selectors to ensure everything can be done
through CSS to keep code out of confusing JS.