Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Feature/panel layout mobile #377

Merged
merged 6 commits into from
Jul 31, 2015

Conversation

msecret
Copy link
Contributor

@msecret msecret commented Jul 28, 2015

This includes completed styling of the mobile panel (which acts more like a modal) minus the links to link and the original image link.

Three fields: "Type", "Report", "Amended" were unknown, so I either used defaults or left off. I will need to know what this information is and looks like from the API.

Layouts larger then mobile look fine, and don't change much at this time.

Used this design:
https://files.slack.com/files-pri/T025AQGAN-F07MWATEG/mobile_2.png\

Here's what it looks like:
screen shot 2015-07-28 at 2 28 10 pm
screen shot 2015-07-28 at 2 28 31 pm

Marco Segreto added 3 commits July 27, 2015 17:04
@msecret
Copy link
Contributor Author

msecret commented Jul 28, 2015

I've checked the tests, and I don't think the failure is relevant. It has to do with a database error:
The command "pg_restore --dbname cfdm_test data/subset.dump --no-acl --no-owner" failed and exited with 1 during .

Marco Segreto added 2 commits July 29, 2015 14:50
Changes the layout so it can easily slide in from the right due to
design reasons.

Removes the "details" aspect of the responsive tables plugin as it's
no longer needed with the panel UI.
@noahmanger
Copy link
Contributor

Aaaalmost there. Looks like the footer is covering the bottom part of the panel though:
screen shot 2015-07-30 at 10 50 45 am

This was done because if the height of the viewport is too short,
the panel will be covered by the footer. This ensures the height is
longer to fit it, but is problematic because the amount is
arbituary.
@noahmanger
Copy link
Contributor

Gah. So it works better, but now the problem is that if you click on a row further down the page, the panel is all the way at the top and you don't realize it's there. Pretty sure this is all from my poorly thought out concept, but let me know if you want to think through it.

@msecret
Copy link
Contributor Author

msecret commented Jul 31, 2015

@noahmanger I'm not experiencing that because the page height shrinks. But yea, lets look at this together, I'm a little unsure of the current design as the viewport units could cause problems.

@noahmanger
Copy link
Contributor

Oh weird. The height's not shrinking for me.

noahmanger pushed a commit that referenced this pull request Jul 31, 2015
@noahmanger noahmanger merged commit a40a533 into fecgov:develop Jul 31, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants