This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Feature/panel layout mobile #377
Merged
noahmanger
merged 6 commits into
fecgov:develop
from
msecret:feature/panel_layout-mobile
Jul 31, 2015
Merged
Feature/panel layout mobile #377
noahmanger
merged 6 commits into
fecgov:develop
from
msecret:feature/panel_layout-mobile
Jul 31, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Styles the panel with the correct marigins based on the design.
I've checked the tests, and I don't think the failure is relevant. It has to do with a database error: |
Changes the layout so it can easily slide in from the right due to design reasons. Removes the "details" aspect of the responsive tables plugin as it's no longer needed with the panel UI.
This was done because if the height of the viewport is too short, the panel will be covered by the footer. This ensures the height is longer to fit it, but is problematic because the amount is arbituary.
Gah. So it works better, but now the problem is that if you click on a row further down the page, the panel is all the way at the top and you don't realize it's there. Pretty sure this is all from my poorly thought out concept, but let me know if you want to think through it. |
@noahmanger I'm not experiencing that because the page height shrinks. But yea, lets look at this together, I'm a little unsure of the current design as the viewport units could cause problems. |
Oh weird. The height's not shrinking for me. |
noahmanger
pushed a commit
that referenced
this pull request
Jul 31, 2015
Feature/panel layout mobile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes completed styling of the mobile panel (which acts more like a modal) minus the links to link and the original image link.
Three fields: "Type", "Report", "Amended" were unknown, so I either used defaults or left off. I will need to know what this information is and looks like from the API.
Layouts larger then mobile look fine, and don't change much at this time.
Used this design:
https://files.slack.com/files-pri/T025AQGAN-F07MWATEG/mobile_2.png\
Here's what it looks like: