Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Styling committee filing filters #362

Merged
merged 2 commits into from
Jul 24, 2015
Merged

Styling committee filing filters #362

merged 2 commits into from
Jul 24, 2015

Conversation

noahmanger
Copy link
Contributor

  1. Tightens up the filters on the filings table on committee pages
    screen shot 2015-07-23 at 3 33 48 pm
  2. Moves the table page controls below tables on the committee page. @jenniferthibault this was the pattern you were using on election pages, correct?
    screen shot 2015-07-23 at 3 34 34 pm

@noahmanger
Copy link
Contributor Author

The tests passed locally for me. Not sure why they're not working here.

@jenniferthibault
Copy link
Contributor

I had the pagination box connected the bottom of the table, because I thought it helped more with visually unifying each element when there were multiple tables in a row. That could change though!

Is it just me, or is the text in the pagination box larger than the text in the table? Could we make sure they are the same size universally? (that, or that the pagination text is the smaller of the two?)

@noahmanger
Copy link
Contributor Author

Nice. I like it:

screen shot 2015-07-23 at 6 33 49 pm

@jmcarp jmcarp merged commit 5e94209 into develop Jul 24, 2015
@noahmanger noahmanger deleted the feature/filings-tab-filters branch August 3, 2015 22:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
plz-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahmanger @jenniferthibault @jmcarp