Feature/itemized tables #302
Conversation
Borrowed from fecgov#302.
|
Sounds like @msecret has some time to review. @noahmanger, would you prefer that we merge this without style updates once the code's in good shape, or do you want to hold off until everything looks nice? @msecret may also be able to help with styles. |
|
Ah yeah that's fine. I just noticed one thing that should be changed though: the "Filing Date" field should actually be "Transaction Date", referring to the date that the contribution was made, not the date of the report it was included in. Right, @LindsayYoung ? |
|
Also, I made decent work on style improvements. I'm fine to pass it off to someone else to finish up. |
|
The next big task here is to implement the details pane in place of the current modal. |
Note: For this work as expected, we have to initialize tables (to expand accordions) after initializing accordions, which is kind of brittle. Open to alternatives @msecret.
Based on discussion in fecgov#312.
Also use uniform badge styles, badges for develop and master.
jmcarp
force-pushed
the
feature/itemized-tables
branch
from
06e5d76 to
4c1702d
Compare
| <div class="modal__row"> | ||
| <h3>Expenditure Detail</h3> | ||
| <nav class="modal__nav"> | ||
| <div class="modal-content"> |
There was a problem hiding this comment.
I think this should be modal__content.
| {{/if}} | ||
| </tr> | ||
| <tr> | ||
| <td>Recipient City & State</td> |
There was a problem hiding this comment.
Handlebars renders this correctly as-is.
…ture/itemized-tables
Previously, loading div would remain on-screen forever after an error, requiring the user to refresh.
Still in progress; not ready for merge!