This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
moving 2nd line of beta warning to h3 #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,8 +61,7 @@ | |||
| <header class="site-header"> | |||
| <div id="notice" aria-hidden="true" class="section--blue"> | |||
| <a id="notice-close" class="js-action js-hide link--icon" tabindex="0" data-hides="notice"><i class="ti-close"></i></a> | |||
| <h3>This is a work in progress</h3> | |||
| <p>This site is in <a href="https://18f.gsa.gov/dashboard/stages/#beta" target="_blank">beta</a>. <a href="/#progress">Find out what’s here and what’s missing</a>.</p> | |||
| <h3>This is a work in progress... this site is in <a href="https://18f.gsa.gov/dashboard/stages/#beta" target="_blank">beta</a>. <a href="/#progress">Find out what’s here and what’s missing</a>.</h3> | |||
There was a problem hiding this comment.
Can we ditch the ellipsis? Seems too informal.
Also, h3 feels real big. How about h4?
I'm not married to ellipsis, but I think it needs some punctuation and "This is a work in progress. This site is in beta." seemed a bit stilted. But maybe it's not that bad?
I don't have it set up locally, so I can't preview, but the current version with "This is a work in progress." alone looked... big and lonely? |
|
@leahbannon @noahmanger Thoughts on combining the two into "This beta site is a work in progress" ?? |
|
How about something that looks like... Welcome to OpenFEC. This beta site is work in progress.Find out what's here and what's missing.Contact us blah blah blah. |
noahmanger
pushed a commit
that referenced
this pull request
Jun 11, 2015
moving 2nd line of beta warning to h3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@noahmanger what do you think?