Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Feature/contextual search box #245

Merged
merged 3 commits into from
Jun 8, 2015

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Jun 8, 2015

Set search type to current page type.

When a user browses to the committee search page or a committee detail
page, set the typeahead search type to committees; else set to
candidates. Update tests accordingly.

[Resolves https://github.com/18F/openFEC/issues/918]

jmcarp added 3 commits June 8, 2015 16:10
When a user browses to the committee search page or a committee detail
page, set the typeahead search type to committees; else set to
candidates. Update tests accordingly.

[Resolves https://github.com/18F/openFEC/issues/918]
@msecret
Copy link
Contributor

msecret commented Jun 8, 2015

@noahmanger do we also want it so when you visit the committees/candidates page, /committees the search will be the page type? Or is that not necessary/expected?

@noahmanger
Copy link
Contributor

Oh good question. I don't actually know. We'll have to ask users. In
general I think best to default to candidates.

On Mon, Jun 8, 2015 at 4:14 PM, Marco Segreto [email protected]
wrote:

@noahmanger https://github.com/noahmanger do we also want it so when
you visit the committees/candidates page, /committees the search will be
the page type? Or is that not necessary/expected?


Reply to this email directly or view it on GitHub
#245 (comment).

Noah Manger
18F http://18f.gsa.gov | Work: 415-696-6146

msecret pushed a commit that referenced this pull request Jun 8, 2015
@msecret msecret merged commit 5075745 into fecgov:develop Jun 8, 2015
@msecret msecret removed the plz-review label Jun 8, 2015
@jmcarp
Copy link
Contributor Author

jmcarp commented Jun 9, 2015

Based on discussion above, we might want to revert a few lines of this patch. Here's the current behavior after merging--@arowla, @noahmanger, @msecret, let me know if anything should be changed.

  • Candidate list page (/candidates): highlight candidates
  • Candidate search page (/?search_type=candidates): highlight candidates
  • Candidate detail page (/candidate/<candidate_id>): highlight candidates
  • Committee list page (/committees): highlight committees
  • Committee search page (/?search_type=committees): highlight committees
  • Committee detail page (/committee/<committee_id>): highlight committees
  • Everything else: highlight candidates

That's what I would expect as a user, but if you have different intuitions, or find otherwise in testing, this is all trivial to change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants