Aggregate committee financials for multiple authorized committees. #233
Conversation
When a candidate has multiple authorized or principal committees, users should see aggregated receipts, cash on hand, etc., across all such committees before the details for each committee. This patch shows these aggregate on the candidate detail page, but only when the candidate has multiple authorized committees. [Resolves fecgov#832]
|
This looks good to me. Is it ready to merge? I think I'll need to do some tinkering to make the attribution notes more readable (all the committee names run together) but that can come later. |
|
The Viewer on fec.gov is not handling cash on hand and debts correctly. A fix will be deployed to UAT today. Generally cash on hand and debt are taken from the most recent report in the period of interest. For example, if the period of interest for a candidate is 2015-2016 the most recent report would be the 2015 April Quarterly (Q1). For candidates with multiple authorized committees (say a principal campaign committee and an other authorized committee), cash on hand and debt are calculated by summing those values from the most recent report in the period of interest for each committee. PCC - 2015 Q1 $10 $10 |
|
And a shorter answer, your McCain example looks good.
|
|
👍 I'm going to merge this then. |
…cials Aggregate committee financials for multiple authorized committees.
When a candidate has multiple authorized or principal committees, users
should see aggregated receipts, cash on hand, etc., across all such
committees before the details for each committee. This patch shows these
aggregate on the candidate detail page, but only when the candidate has
multiple authorized committees.
@dcpcc1967 and @jwchumley: Aggregated cash on hand and debt are different from the current FEC site. The logic implemented here simply adds up cash and debt for the most recent report for all relevant committees; it looks like FECViewer is picking a single committee and using its most recent figures, but it's not clear how that committee is chosen. Figures for receipts and disbursements have been identical for the examples I've looked at.
The proposed layout looks like this (any feedback or PRs welcome!):
[Resolves #832]