This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Ensures charts properly deal with negative values #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user sees a chart for a negative value, they should see a bar chart of zero. TODO: A better implementation of this would be to actually show a negative value through a different kind of chart or a different color, but this requires design consideration.
noahmanger
pushed a commit
that referenced
this pull request
Jun 2, 2015
…atives Ensures charts properly deal with negative values
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user sees a chart for a negative value, they should see a
bar chart of zero.
TODO:
A better implementation of this would be to actually show a negative
value through a different kind of chart or a different color, but this
requires design consideration.