Changed FEC PDF links to be built by a filter #194
Conversation
- Added check in template to make sure we don't try building a non-existent link
| </div> | ||
| <div class="table__row--note"> | ||
| Source: <a href="http://docquery.fec.gov/pdf/{{ reports.beginning_image_number|last_n_characters }}/{{ reports.beginning_image_number }}/{{ reports.beginning_image_number }}.pdf">{{reports.report_type_full|fmt_report_desc|default("unavailable")}} {{ reports.report_year }}</a> | ||
| {% if report %} | ||
| Source: <a href="{{ report|url_to_fec_pdf }}">{{report.report_type_full|fmt_report_desc|default("unavailable")}} {{ report.report_year }}</a> |
There was a problem hiding this comment.
Can this code lead to a case where we generate HTML like <a href="unavailable">...</a>? Disregard previous comment--this is the question I meant to ask 😃
There was a problem hiding this comment.
I checked the behavior on /candidate/H2OH06086... It takes the "else" route and says "Source: None".
There was a problem hiding this comment.
Good. But if that's the case, then is the default("unavailable") logic on this line unreachable? If so, seems like we don't need it, and if not, this could lead to an edge case where we get "unavailable" in the URL.
There was a problem hiding this comment.
Well in this case, the "unavailable" is only in the case that we don't have a full report description. We ought to have that if we have a report, but I'm not 100% certain if that will always be the case. So what if we replace the default link text "unavailable" with something like default("Committee Report")?
- Went with just "Report" to be totally generic.
| </div> | ||
| <div class="table__row--note"> | ||
| Source: <a href="http://docquery.fec.gov/pdf/{{ reports.beginning_image_number|last_n_characters }}/{{ reports.beginning_image_number }}/{{ reports.beginning_image_number }}.pdf">{{reports.report_type_full|fmt_report_desc|default("unavailable")}} {{ reports.report_year }}</a> | ||
| {% if report %} | ||
| Source: <a href="{{ report|url_to_fec_pdf }}">{{report.report_type_full|fmt_report_desc|default("Report")}} {{ report.report_year }}</a> |
There was a problem hiding this comment.
@jmcarp I went ahead and changed the default report text to read just "Report" in the case that we have a report but for some reason the report_type_full is not filled in. Does that work, do you think?
non-existent link