Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Bug: many committees cycle selections not working #875

Closed
LindsayYoung opened this issue Oct 21, 2015 · 3 comments
Closed

Bug: many committees cycle selections not working #875

LindsayYoung opened this issue Oct 21, 2015 · 3 comments
Labels
Bug

Comments

@LindsayYoung
Copy link
Contributor

Just noticed

Not working:
https://fec-proxy.18f.gov/data/committee/C00507384/?cycle=2010
https://beta.fec.gov/data/committee/C00507384/?cycle=2010

Working:
https://fec-proxy.18f.gov/data/committee/C00507384/
https://beta.fec.gov/data/committee/C00508002/

More examples that work the same on dev and production:
https://beta.fec.gov/data/committee/C00443176/?cycle=2006
https://beta.fec.gov/data/committee/C00508002/?cycle=2010
@jmcarp jmcarp self-assigned this Oct 21, 2015
@jmcarp
Copy link
Contributor

jmcarp commented Oct 21, 2015

Looks like we caused this in #1202. We're getting the list of active two-year periods from vw_filing_history, but we're populating most other fields in ofec_committee_history_mv using dimcmteproperties. So for committee C00507384, we think we'll get data for 2008-2016, but we only have records in dimcmteproperties from 2010-2016. That's because this committee filed a few F3s before its first F1--meaning we have fundraising data before we have basic information about the committee.

We probably don't want to roll back #1202, since that would reintroduce problems with ECs and CCs. We could use a full outer join to join dimcmteproperties on cycles, but then we'd wind up showing committee pages with mostly null values. We could also show the next available F1 for the committee, but that would mean sometimes looking into the future to populate the committee detail page, which strikes me as a bad idea.

What do you think @LindsayYoung? This may be another item to add to discussions on Friday.

@LindsayYoung
Copy link
Contributor Author

I think that full outer join with showing committee pages with mostly null values might be the best we can do. Especially if we ever add back ballot candidates, they won't have any summary data or even filings.

@jmcarp jmcarp mentioned this issue Oct 22, 2015
Closed
jmcarp added a commit to jmcarp/openFEC that referenced this issue Oct 23, 2015
@jmcarp
Temporarily fetch committee type from detail table.
b4ee72d 
Due to a mismatch in active cycles between `dimcmteproperties` and
`vw_filing_history`, some committee reports and totals return 404s on
attempting to resolve the committee type when a cycle is specified. This
patch temporarily falls back to resolving committee type from the detail
table when no matching results can be found for the specified cycle.

Note: this should be reverted after the underlying issue described in
fecgov/openFEC-web-app#875 is resolved.
@jmcarp jmcarp mentioned this issue Oct 23, 2015
Merged
jmcarp added a commit to jmcarp/openFEC-web-app that referenced this issue Oct 23, 2015
@jmcarp
Temporarily fetch committee information from detail table.
5758386 
When committee history information can't be found from the history
sub-endpoint, use the detail endpoint instead. This is a temporary fix
and should be reverted once the underlying issue described in
fecgov#875 is resolved.

Depends on https://github.com/18F/openFEC/pull/1295.
@jmcarp jmcarp mentioned this issue Oct 23, 2015
Merged
@jmcarp
Copy link
Contributor

jmcarp commented Oct 24, 2015

@LindsayYoung and I put in a temporary fix for this to avoid problems during launch. Let's continue discussion of a better solution in https://github.com/18F/openFEC/issues/1287.

@jmcarp jmcarp closed this as completed Oct 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmcarp @LindsayYoung