Bug: Report totals missing from details panel

[noahmanger]

Just happened to notice this while clicking around on this page

The details panel is missing all kinds of numbers, but those are reported on the form and on the committee page the numbers are there:

Not sure how we can figure out if this is a broader pattern.

[noahmanger]

Update! I realized that in one case I was looking at the Amended report (that's the one that has the data) and one was looking at the New report. The New one in both pages misses the data.

[noahmanger]

And even in this case, do we want the links to "Source forms" to only link to New reports?

[jmcarp]

There's a discrepancy between the way we handle filings in general and the way we handle F3* forms. We discard all F3, F3P, and F3X forms with non-null expiration dates (meaning they've been amended). For filings in general, we keep both new and amended filings. The result is that when we try to load detailed data for a filing that's been amended, we don't get any results, because we've discarded F3* data for those records.

To fix, it seems like we'll want to make the behavior consistent by either including both amended and non-amended F3* forms, or by discarded amended filings in general. I generally lean toward exposing more data, so my first thought would be the first option.

What do you think @noahmanger @LindsayYoung @PaulClark2?

[jmcarp]

Just to be clear, we'll definitely want to continue to exclude F3* forms from our two-year aggregates.

[LindsayYoung]

I like the idea of adding the amended report details. We would need to amend the api call that makes the charts on the financial summary on the committee pages.

When these were on the committee pages, we showed nulls as none with a link to none in the glossary. Maybe that would be a good approach here.

[noahmanger]

Ah got it. This is tricky. I agree that it's good to show the original numbers and the new numbers, but this requires some design work, I think. I could see a couple options:

1. In the details panel for amended filings, show the original numbers and the new numbers above or below them.
2. Just show the old numbers, but with a banner saying that the filings has been amended and linking to the amendment.

Or maybe a combination of the two.

Still I don't get why some of the numbers on the amended form show up and not others? Shouldn't it all be blank?

[LindsayYoung]

We can't link to the new one yet. We don't have the "amended by" information but that is one of the things I think we will cover in the data meeting.

We can add a banner saying that record has been amended.

[noahmanger]

So can we even show the new numbers in that case?

[LindsayYoung]

We show the new numbers on the new form.

I am a little confused. I don't think I am understanding your question. This view is about the forms, so we would not want to show the numbers for another form on the form we are viewing, right?

[PaulClark2]

So the issue here is being able to show the summary/detailed summary information for all financial forms, new or amended, correct? I guess there are a few ways to do this: display the data on the details panel (this might take more time to do) or, perhaps, a short-term fix provide a link to the image for the filings that are not the most recent.

[jmcarp]

@PaulClark2: we proposed a fix in https://github.com/18F/openFEC/pull/1289. Instead of excluding all amended F3* records at the level of the materialized views, we're now including them and adding a filter to hide or show them as needed. That means we can fetch the relevant data for the details pane for records that have been amended.