Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Candidate cycle dropdown should apply to statements, not candidates #120

Closed
jmcarp opened this issue May 4, 2015 · 1 comment
Closed

Comments

@jmcarp
Copy link
Contributor

jmcarp commented May 4, 2015

Currently, selecting an election cycle on a candidate detail page (e.g. 2013-2014) sends a request to the API at /candidate/<candidate_id>?year=<year>. Then we request all financial statements associated with that candidate's committees--meaning we don't apply the election cycle filter to the statement listing. I may be interpreting this incorrectly, but I would think that we should be filtering the statements by year instead of the candidate. This will be possible once @LindsayYoung's new /reports and /totals endpoints are added, so that we can send a request to e.g. /reports?candidate_id=<candidate_id>&year=<year>.

We will want to fix this before re-enabling the cycle filter on the candidate detail page, which FEC has requested we fix soon.

@jmcarp
Copy link
Contributor Author

jmcarp commented May 4, 2015

@jmcarp jmcarp closed this as completed May 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant