Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document title never changes throughout site #699

Closed
toolness opened this issue Nov 22, 2017 · 2 comments
Closed

Document title never changes throughout site #699

toolness opened this issue Nov 22, 2017 · 2 comments
Assignees
@cmc333333 @rememberlenny
Milestone
Tortellini Sprint

Comments

@toolness
Copy link
Contributor

toolness commented Nov 22, 2017 •
edited
Loading

I've noticed that the document title (i.e., the text on the user's browser tab, and what is announced to screen readers) is always "OMB Policy Library (Beta)". It seems like we should add details about what particular page they're on, e.g. "Search results for 'data center'" or "M-16-19: Data Center Optimization Initiative (DCOI)".

This would make it particularly easy for folks who might have multiple browser tabs open, each on a different page of the site, but it's most important for visually-impaired users (see #700).

In the React a11y talk, react-document-title is mentioned as a nice component that makes this particularly easy, though perhaps NextJS already has something built-in.
@toolness toolness mentioned this issue Nov 22, 2017
Open
@cmc333333
Copy link
Contributor

I'd bet the <Head> tag w/ keyed attributes will be important here: https://github.com/zeit/next.js/#populating-head

@yowill yowill added this to the Spaghetti Sprint milestone Dec 4, 2017
@rememberlenny rememberlenny self-assigned this Dec 5, 2017
@cmc333333 cmc333333 self-assigned this Dec 18, 2017
@cmc333333
Copy link
Contributor

Resolved by #776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmc333333 cmc333333

@rememberlenny rememberlenny

Labels
None yet
Projects
None yet
Milestone
Tortellini Sprint
Development

No branches or pull requests
4 participants
@toolness @cmc333333 @yowill @rememberlenny