Skip to content
This repository has been archived by the owner on Jun 15, 2022. It is now read-only.

more graceful error handling for rule-file parsing #104

Open
cryptofilegsa opened this issue Dec 8, 2016 · 5 comments
Open

more graceful error handling for rule-file parsing #104

cryptofilegsa opened this issue Dec 8, 2016 · 5 comments

Comments

@cryptofilegsa
Copy link
Contributor

A rule file that fails to be parsed can produce an error that looks like this:
Configuring Seekret
yaml: unmarshal errors:
line 1: cannot unmarshal !!str Not Found into seekret.ruleYaml

Would be nice to handle failed rule files with a try...catch in such a way that their failure to be parsed did the following:

  1. named the culprit rule file(s)
  2. did not make git-seekrets hard fail
  3. contained a link to where or how to get the most updated/best/fixed rules
@monfresh
Copy link
Contributor

monfresh commented Dec 8, 2016

@cryptofilegsa I'm a little confused about these issues. I don't think the laptop script uses seekret yet, right? That's still a work in progress as far as I know, in this PR: #69

If the issue is with the ongoing work, could you please post a comment in PR #69 as opposed to creating an issue? The issues are meant for bugs with what's in the master branch.

Thanks!

@monfresh
Copy link
Contributor

monfresh commented Dec 8, 2016

I see now that there's a Project in this repo called git seekret, where you all have been tracking these issues. I haven't used Projects in GitHub before, hence my confusion. Is this how Projects are meant to be used? It feels strange to me to have issues show up for WIP branches.

@monfresh
Copy link
Contributor

monfresh commented Dec 8, 2016

Currently, there doesn't seem to be an easy way to filter issues so that only the ones that affect the master branch show up, which is my concern.

@mgwalker
Copy link
Member

Should this issue be in the git-seekret repo? This repo contains the rules, but I assume parsing and error handling happens in the git-seekret code.

@its-a-lisa-at-work
Copy link

Deleting as stale based on the TTS Tech Portfolio Deep Grooming session from 3/30/20; if you have any questions, comments or concerns, please let us know either in the #infrastructure or #tts-tech-portfolio slack channels

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants