Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Checks for Attachments (Post-OSCAL Still Conventional Attachments) #52

Closed
10 tasks done
ohsh6o opened this issue Mar 30, 2021 · 4 comments · Fixed by #108
Closed
10 tasks done

Checks for Attachments (Post-OSCAL Still Conventional Attachments) #52

ohsh6o opened this issue Mar 30, 2021 · 4 comments · Fixed by #108
Assignees
Labels
epic schematron code a category of validations to implement
Milestone

Comments

@ohsh6o
Copy link

ohsh6o commented Mar 30, 2021

Prior to OSCAL, CSPs, 3PAOs, and FedRAMP Review Team members would edit the FedRAMP Microsoft Word template. Some of the artifacts below would be inline tables in the Word document, where as others would be discrete attachments. We need to account for this transition, and confirm whether or not it is an attachment.

For those attachments that do not explicitly have their own definition in the OSCAL model, we must review and determine the appropriate strategy for porting it into the attachment model of NIST/FedRAMP system security plans, in XPath notation these items are in /o:back-matter/o:resource. Some may be in the NIST OSCAL namespace (@ns="http://csrc.nist.gov/ns/oscal/1.0" or @ns is unset, which is default and means OSCAL core is presumed) or the FedRAMP namespace (@ns="https://fedramp.gov/ns/oscal"), so some due diligence ought to be performed.

Relevant documentation from FedRAMP to work on the acceptance criteria below, specifically the table.

Preconditions:

  • A working definition, confirmed with the FedRAMP PMO, of "minimally viable validation" for documents that are attachments and not first-class OSCAL objects, documented and included with developer documentation in this repo.

Acceptance Criteria:

  • A clear, explanatory validation message with an associated test indicating the Information Security Policies and Procedures is or is not properly attached as resource/link and properly referenced in OSCAL.
  • A clear, explanatory validation message with an associated test indicating the User Guide is or is not properly attached as resource/link and properly referenced in OSCAL.
  • A clear, explanatory validation message with an associated test indicating the Rules of Behavior is or is not properly attached as resource/link and properly referenced in OSCAL.
  • A clear, explanatory validation message with an associated test indicating the Information System Contingency Plan (ISCP) is or is not properly attached as resource/link and properly referenced in OSCAL.
  • A clear, explanatory validation message with an associated test indicating the Configuration Management Plan (CMP) is or is not properly attached as resource/link and properly referenced in OSCAL.
  • A clear, explanatory validation message with an associated test indicating the Incident Response Plan (IRP) is or is not properly attached as resource/link and properly referenced in OSCAL.
  • A clear, explanatory validation message with an associated test indicating the Control Implementation Summary (CIS) Workbook is or is not properly attached as resource/link and properly referenced in OSCAL.
  • A clear, explanatory validation message with an associated test indicating the Separation of Duties Matrix is or is not properly attached as resource/link and properly referenced in OSCAL.
  • A clear, explanatory validation message with an associated test indicating the FedRAMP Laws and Regulations is or is not properly attached as resource/link and properly referenced in OSCAL.
FedRAMP SSP Template Location Description OSCAL XML Model Location Notes
§15 Attachment 1 Information Security Policies and Procedures /system-security-plan/back-matter/resource/prop[@name="type" and . = "plan"] Text value too vague, needs more focused value in FedRAMP values to filter on
§15 Attachment 2 User Guide /system-security-plan/back-matter/resource/prop[@name="type" and . = "guidance"] Text value too vague, needs more focused value in FedRAMP values to filter on
§15 Attachment 5 Rules of Behavior (ROB) /system-security-plan/back-matter/resource/prop[@name="type" and . = "TBD"] Text value too vague, needs more focused value in FedRAMP values to filter on
§15 Attachment 6 Information System Contingency Plan (ISCP) /system-security-plan/back-matter/resource/prop[@name="type" and . = "plan"] Text value too vague, needs more focused value in FedRAMP values to filter on
§15 Attachment 7 Configuration Management Plan (CMP) /system-security-plan/back-matter/resource/prop[@name="type" and . = "plan"] Text value too vague, needs more focused value in FedRAMP values to filter on
§15 Attachment 8 Incident Response Plan (IRP) /system-security-plan/back-matter/resource/prop[@name="type" and . = "plan"] Text value too vague, needs more focused value in FedRAMP values to filter on
§15 Attachment 9 Control Implementation Summary (CIS) Workbook (dynamically generated) This is no longer an attachment, see Guide to OSCAL-Formatted SSP Section 7.1
§15 Attachment 11 Separation of Duties Matrix /system-security-plan/back-matter/resource/prop[@name="type" and . = "TBD"] Text value too vague, needs more focused value in FedRAMP values to filter on
§15 Attachment 12 FedRAMP Laws and Regulations /system-security-plan/back-matter/resource/prop[@name="type" and . = "law"] Already attached in pre-configured OSCAL templates unless tampered with
@ohsh6o ohsh6o added epic schematron code a category of validations to implement labels Mar 30, 2021
@mike-stern mike-stern added this to the sprint 1 milestone May 6, 2021
@ohsh6o
Copy link
Author

ohsh6o commented May 7, 2021

Re this @danielnaab:

A working definition, confirmed with the FedRAMP PMO, of "minimally viable validation" for documents that are attachments and not first-class OSCAL objects, documented and included with developer documentation in this repo.

@ohsh6o will take an action item in a separate task to figure that out and define it properly in #74.

@danielnaab
Copy link
Member

If I understand correctly, the following documents do not need to be attached, and should instead have their contents entered via structured data. We may need a separate ticket to track adding the validation rules for these, if we aren't separately tracking the corresponding sections of the FedRAMP SSP guide.

  • Digital Identity Worksheet, see: "Digital Identity Determination"
  • Privacy Threshold Analysis (PTA), see: "Privacy Impact Assessment"
  • CIS Workbook, see: Security Controls
  • FIPS-199, see: Security Objectives Categorization (FIPS-199)
  • Inventory, see: System Inventory

@ohsh6o
Copy link
Author

ohsh6o commented May 14, 2021

If I understand correctly, the following documents do not need to be attached, and should instead have their contents entered via structured data.

That seems right to me. I will review and make sure we are on the same page Monday.

We can break down the story into different tasks, or split out the story. I point this out because, from the perspective of the FedRAMP reviewer (FART or JAB), in their review checklist, they as users will want error messaging that discusses them in the current state of affairs: as attachments.

Maybe we conceive the existence checks of them in output as Section B attachment failures, and validating the details of those structures "somewhere else" in a way you or I have not thought of yet.

Make sense?
I am

@danielnaab
Copy link
Member

We can break down the story into different tasks, or split out the story. I point this out because, from the perspective of the FedRAMP reviewer (FART or JAB), in their review checklist, they as users will want error messaging that discusses them in the current state of affairs: as attachments.

Makes sense - methinks we could wrap the back-matter scenario inside an attachment one, to handle the two cases in a consistent way.

@ohsh6o ohsh6o modified the milestones: Sprint 1, Sprint 2 May 19, 2021
@mike-stern mike-stern linked a pull request May 20, 2021 that will close this issue
@mike-stern mike-stern modified the milestones: Sprint 2, Sprint 3 Jun 2, 2021
@ohsh6o ohsh6o changed the title As a FedRAMP reviewer, to be sure all required artifacts are included with a system security plan, I want validations to indicate all "Section B" attachments are present and valid. Checks for Attachments (Post-OSCAL Still Conventional Attachments) Jun 16, 2021
@sstatz sstatz modified the milestones: Sprint 3, Sprint 4 Jun 16, 2021
This was referenced Jun 16, 2021
@GaryGapinski GaryGapinski linked a pull request Jun 25, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
epic schematron code a category of validations to implement
Projects
None yet
5 participants