-
Notifications
You must be signed in to change notification settings - Fork 8
Design & visual styling review of FEC Records #614
Comments
Comments from reviewers:
|
I'm adding a few thoughts from my own review so that I won't lose track of them, but will come back to sort and respond to the questions and points above. Thanks so much for collecting these, Amy!
|
Just made several of these changes in https://github.com/18F/fec-cms/issues/752 . I have separate thoughts on the image issue which I'll post there. |
Going to close this since the review is complete, but next steps are to file issues for the outstanding feedback we should address before release. |
Oops, that was a little early. I should have probably left the issue open so we don't lose it, but move it to "Done" |
✅ We've heard this feedback on other items in the Latest Updates as well. That style has been removed from the Record templates. It will be removed from other templates by https://github.com/18F/fec-cms/issues/788
✅ These sections are the categories users can select from the drop-down, which allows you to filter down to viewing all reports for that category. This was implemented in the last release.
Definitely agreed! Issue filed for this: #622
✅ The Latest updates page will allow users to filter by both date and category, so I believe the same functionality should exist, even though it will look a little different.
Issue filed for this: https://github.com/18F/fec-cms/issues/790
Issue discussing image treatment and approach: https://github.com/18F/fec-cms/issues/549
✅ Done! This was a planned feature and I'm happy to report that will be implemented in this week's release: https://github.com/18F/fec-cms/pull/752
✅ Updated to sentence case for consistency and will be part of this week's release: https://github.com/18F/fec-cms/pull/752
Related posts are generated programmatically by date, but can be overwritten manually. Related section appears to have been set to "data" by default, but should probably be empty
The biggest concern is that this change would be duplicative, and the feed item would say "FEC Record" in two places very close to one another. The secondary concern is that this is the only place that we say who publishes this content. Otherwise the Info Div piece is totally lost for readers.
✅ We can easily implement this to display any email address and contact info, but we aren't sure what it should say. New issue to track this: https://github.com/18F/fec-cms/issues/791
✅ We've changed the interaction so that when you select a tag, instead the page skips the Title content and anchors the dropdowns at the top of the screen. That way, we hypothesize that users can tell the content changed more easily. Other issues filed: Closing this issue since each item can now be tracked independently |
Thank you @jenniferthibault ! |
Thank you @jenniferthibault - going through it all now! |
Review:
Access pages in production while signed into the CMS.
Review & implemented improvements should happen before release
The text was updated successfully, but these errors were encountered: