Skip to content
This repository has been archived by the owner on Sep 12, 2019. It is now read-only.

Fixing IE8, 9, 10 support #485

Open
cmc333333 opened this issue Jul 24, 2017 · 1 comment
Open

Fixing IE8, 9, 10 support #485

cmc333333 opened this issue Jul 24, 2017 · 1 comment
Milestone

Comments

@cmc333333
Copy link
Contributor

cmc333333 commented Jul 24, 2017

eRegs currently breaks in IE8, 9, and 10 (it's fine in IE11). With some preliminary testing, a significant chunk of this problem rests in our inclusion of prosemirror (which is included for notice and comment). There are a few things we should/can do to fix this:

  • We currently only run integration tests on Chrome and IE11. Expand this to the browsers we actually want to support
  • ProseMirror is out of date. Hypothetically updating it would fix an issue with IE10. This may not be relevant if we implement the next point.
  • Perhaps more importantly, ProseMirror isn't required for any active site right now. It'd make sense to split that component out. The Python's being split in Split comment-related functionality into separate Python module eregs/regulations-site#491, but the JS is always included.
  • We probably want to include the babel-polyfill to account for ES6 features not present in earlier browsers (though we may not be using those features yet).
@cmc333333 cmc333333 added this to the Jiggle! Sprint milestone Jul 24, 2017
@cmc333333 cmc333333 modified the milestones: The Abyss, Jiggle! Sprint Aug 2, 2017
@cmc333333
Copy link
Contributor Author

Collectively, IE8, 9, and 10 make up less than 1 percent of the DOJ's audience. While https://github.com/eregs/regulations-site/tree/485-split-nc-js fixes IE10, let's hold off until we have integration tests for these browsers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant