Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public metrics page #387

Closed
GUI opened this issue May 27, 2017 · 1 comment
Closed

Fix public metrics page #387

GUI opened this issue May 27, 2017 · 1 comment

Comments

@GUI
Copy link
Member

GUI commented May 27, 2017

After the API Umbrella v0.14 upgrade (#382), the one thing that seems to have broken is our public metrics page: https://api.data.gov/metrics/

The issue seems to be the that the mongoid caching plugin we use in the Rails app isn't compatible with the newer version of mongoid (and we're missing test coverage on this public metrics endpoints, since it was sort of done as a one off).

@GUI
Copy link
Member Author

GUI commented Jun 16, 2017

Fixed and more tests added to make sure this doesn't regress: NREL/api-umbrella@3187452

https://api.data.gov/metrics/

Although, now the only potential issue is that we've passed 1 billion requests served so the number formatting with thousands of millions looks a bit odd. But that's a better problem to have. 🚀

@GUI GUI closed this as completed Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant