Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlimited rate limit settings can be ineffective in specific situation #201

Closed
GUI opened this issue Mar 19, 2015 · 1 comment
Closed

Unlimited rate limit settings can be ineffective in specific situation #201

GUI opened this issue Mar 19, 2015 · 1 comment

Comments

@GUI
Copy link
Member

GUI commented Mar 19, 2015

This issue was brought to our attention today:

  • An API backend was configured with the rate limit set to "Unlimited requests"
  • The API backend also had a role requirement set on it.
  • An API key with that role assigned to it was being used to access the API, but was periodically hitting 429 rate limit errors.

After digging into this, the problem was specific to any situation where an API backend was setup with "Unlimited requests" and the user accessing it had been edited and left with the "default" rate limits applied. Only when these two requirements were met, the unlimited rate limit setting at the API backend level was effectively nullified. Any other combination of situations (custom rate limits or API users that hadn't been edited in the admin) would have worked as expected, it was just this one combination that it seemed like we weren't handling properly.

@GUI GUI added this to the Sprint 17 (3/9-3/20) milestone Mar 19, 2015
@GUI GUI self-assigned this Mar 19, 2015
@GUI
Copy link
Member Author

GUI commented Mar 19, 2015

Fixed and test coverage for this combination added with: NREL/api-umbrella-gatekeeper@0b0ec82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant