Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test suite #112

Closed
GUI opened this issue Aug 19, 2014 · 2 comments
Closed

Add integration test suite #112

GUI opened this issue Aug 19, 2014 · 2 comments
Assignees

Comments

@GUI
Copy link
Member

GUI commented Aug 19, 2014

One thing we've needed for a while is a test suite we can run to test the entire API Umbrella software stack, with all the components in place. While we have fairly good test coverage on the gatekeeper project (where most of the custom code lives), we've been lacking formal tests on the integration of the other important components, which includes things like nginx and varnish:

router-46bdc5fa

For example, having such an integration test suite would help test bugs like these (and also ensure regressions don't pop up):

@GUI GUI added this to the Sprint 4 (8/15-8/29) milestone Aug 19, 2014
@GUI
Copy link
Member Author

GUI commented Aug 19, 2014

This is one of the sizable tasks that sort of got wrapped up in the effort to work on agency-specific admin privileges and re-enabling the caching layer (but I wanted to split it out, since it had become a distinct beast). Basically, having this kind of test suite will make it much easier for us to tackle these type of tasks that touch multiple components of the stack (and we'll be able to do so with much more confidence moving forward).

The good news is that that I now have this full integration test suite to a point where I'm feeling pretty good about it testing our full stack (and I've discovered some odd edge-cases we're now better handling in the process). There's still definitely areas we could use more testing, but the foundation of the important pieces are there. The primary focus of the integration test suite has been on general proxying behavior, gzip handling, and caching behavior (since these are the super important pieces we don't mess up or unexpectedly change). Some initial integration tests related to rate limits and analytics logging have also been added.

This testing work is currently sitting out out on the config branches (and is tied to the move toward the omnibus installer):
https://github.com/NREL/api-umbrella-router/tree/config
https://github.com/NREL/api-umbrella-gatekeeper/tree/config

This work hasn't made its way to master yet, so it's not quite done, but I'm hoping to tackle some of the last pieces necessary to get those branches merged as part of this milestone.

@GUI GUI self-assigned this Aug 21, 2014
@GUI
Copy link
Member Author

GUI commented Oct 13, 2014

These integration tests have made their way to master as part of #123

@GUI GUI closed this as completed Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant