Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanoid verison is vulnerable to GHSA-mwcw-c2x4-8c55 #218

Open
marcthe12 opened this issue Dec 15, 2024 · 3 comments
Open

nanoid verison is vulnerable to GHSA-mwcw-c2x4-8c55 #218

marcthe12 opened this issue Dec 15, 2024 · 3 comments

Comments

@marcthe12
Copy link

The package uses nanoid 4.0 series which is vulnerable to GHSA-mwcw-c2x4-8c55.

There is a fix with version 5.0.9 which is a major release although from documentation it seem that not porting will be required. Another option is to drop it as it is used in one place so some other api can be used in place (maybe something in node:crypto)

@marcthe12 marcthe12 changed the title nanoid verison is vulnerable to https://github.com/advisories/GHSA-mwcw-c2x4-8c55 nanoid verison is vulnerable to GHSA-mwcw-c2x4-8c55 Dec 15, 2024
@voxpelli
Copy link

Its used in one place and only if one isn't providing an override: 'webc-' + nanoid(5)

And that is very much an integer value :) So the security issue is not applicable here

@Eric-Arellano
Copy link

So the security issue is not applicable here

It still results in the supply chain having a vulnerable dependency, which causes security tooling to complain about the risk. So, it's helpful to remove the dep on nanoid or upgrade to v5.

@marcthe12
Copy link
Author

Definitely through, it seems harmless but it still adds noise and also has a risk. As I said, it probably does not even need to port just bump but that for the devs to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants