Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to expand WebC components inside shadow roots #117

Closed
jaredcwhite opened this issue Feb 25, 2023 · 3 comments
Closed

Ability to expand WebC components inside shadow roots #117

jaredcwhite opened this issue Feb 25, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@jaredcwhite
Copy link

Apologies if this is documented somewhere (and I know some things just changed in v0.9), but I'd like to be able to write declarative shadow DOM templates inside of .webc files and still get the ability to expand additional components in the template. From what I can tell, the WebC processing "magic" doesn't dive into the <template shadowrootmode="open"> tag, which might be reasonable as a default but I'd definitely like to be able to switch it back on (maybe with another webc: directive of some kind)? TIA 😃

@zachleat zachleat added the enhancement New feature or request label Feb 27, 2023
@zachleat
Copy link
Member

HMMMMMMMMMMMMM yeah, I think you’re absolutely right here. WebC uses an implied webc:raw on declarative shadow DOM templates which hampers their power.

What we really want is an opt-out for asset bundling, I think? webc:nobundle so that stylesheets and scripts aren’t bundled.

@jaredcwhite
Copy link
Author

@zachleat Yeah, I would expect style tags remain in place so they get sent over inside the DSD template.

@zachleat zachleat added this to the WebC v0.11.3 milestone Apr 6, 2023
@zachleat
Copy link
Member

zachleat commented Apr 6, 2023

Removing implicit webc:raw on Declarative Shadow DOM nodes and adding an implicit webc:nobundle here—this shouldn’t require app code changes to keep current behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants