-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass template context to the Markdown engine #643
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5118d60
Pass current template data to the Markdown engine
4d5d33a
Add tests to see that we send context data through Markdown to plugins
75423bd
Merge remote-tracking branch 'upstream/master'
941c2a4
Merge remote-tracking branch 'upstream/master'
a689764
Update test to check that changes made by a plugin surface in the fin…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import test from "ava"; | ||
import TemplateRender from "../src/TemplateRender"; | ||
import md from "markdown-it"; | ||
|
||
const createTestMarkdownPlugin = () => { | ||
const plugin = md => { | ||
md.core.ruler.after("inline", "replace-link", function(state) { | ||
plugin.environment = state.env; | ||
return false; | ||
}); | ||
}; | ||
plugin.environment = {}; | ||
return plugin; | ||
}; | ||
|
||
test("Markdown Render: with HTML prerender, sends context data to the markdown library", async t => { | ||
let tr = new TemplateRender("md"); | ||
|
||
const plugin = createTestMarkdownPlugin(); | ||
let mdLib = md().use(plugin); | ||
tr.engine.setLibrary(mdLib); | ||
|
||
const data = { some: "data" }; | ||
|
||
let fn = await tr.getCompiledTemplate("[link text](http://link.com)"); | ||
let result = await fn(data); | ||
t.deepEqual(plugin.environment, data); | ||
}); | ||
|
||
test("Markdown Render: without HTML prerender, sends context data to the markdown library", async t => { | ||
let tr = new TemplateRender("md"); | ||
|
||
const plugin = createTestMarkdownPlugin(); | ||
let mdLib = md().use(plugin); | ||
tr.engine.setLibrary(mdLib); | ||
tr.setHtmlEngine(false); | ||
|
||
const data = { some: "data" }; | ||
|
||
let fn = await tr.getCompiledTemplate("[link text](http://link.com)"); | ||
let result = await fn(data); | ||
t.deepEqual(plugin.environment, data); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you drop the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell the comment is not relevant anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @MadeByMike mentioned, the comment says, "throw away data", but we're not throwing away the data any more.