Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquid includes and subdirectories with dynamicPartials: false #73

Closed
zachleat opened this issue Mar 3, 2018 · 5 comments
Closed

Liquid includes and subdirectories with dynamicPartials: false #73

zachleat opened this issue Mar 3, 2018 · 5 comments
Labels
bug
Milestone
v0.3.5

Comments

@zachleat
Copy link
Member

zachleat commented Mar 3, 2018

Filed to track progress on harttle/liquidjs#61 but most commentary for this issue is currently documented in #72.
@zachleat zachleat mentioned this issue Mar 3, 2018
Closed
@zachleat
Copy link
Member Author

zachleat commented Mar 5, 2018

harttle/liquidjs#62

@zachleat zachleat added the bug label Mar 5, 2018
@zachleat
Copy link
Member Author

Still broken as of [email protected]

@zachleat
Copy link
Member Author

4.0.0 is out and we’ve upgraded here without any regressions. Need to revisit this issue specifically—especially after this new comment harttle/liquidjs#62 (comment) Only 6 skipped tests now.

@zachleat
Copy link
Member Author

Related: #122

@zachleat
Copy link
Member Author

This is confirmed working!

Note that if your partial names are quoted, it does require the dynamicPartials option to be enabled.
https://github.com/11ty/eleventy/blob/master/docs/engines/liquid.md#use-your-own-options

@zachleat zachleat added this to the Next Minor Version milestone May 13, 2018
@zachleat zachleat mentioned this issue Jul 21, 2018
Closed
@zachleat zachleat mentioned this issue Sep 6, 2018
Closed
@zachleat zachleat mentioned this issue Sep 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.3.5
Development

No branches or pull requests
1 participant
@zachleat