Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing page.url into a Liquid shortcode fails with Invalid Syntax error #600

Closed
zachleat opened this issue Jul 8, 2019 · 2 comments
Closed

Passing page.url into a Liquid shortcode fails with Invalid Syntax error #600

zachleat opened this issue Jul 8, 2019 · 2 comments
Labels
bug
Milestone
0.9.0

Comments

@zachleat
Copy link
Member

zachleat commented Jul 8, 2019 

{% pagedoturlshortcode page.url %}

fails due to custom argument parsing written for #364

image

Reported by @andybelldesign at https://twitter.com/andybelldesign/status/1148214434709606402?s=20
@zachleat zachleat added the bug label Jul 8, 2019
@zachleat zachleat added this to the Next Minor Version milestone Jul 23, 2019
@zachleat
Copy link
Member Author

Shipping in the next version!

@Andy-set-studio
Copy link

Nice work mate 🙂

zachleat added a commit that referenced this issue Jul 23, 2019
@zachleat
Adds two more tests for #600.
31c93bc
@snyk-bot snyk-bot mentioned this issue Nov 30, 2019
Open
@aakoch aakoch mentioned this issue Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@zachleat @Andy-set-studio