Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for $INPUT/.gitignore (0.7.0 added $ROOT/.gitignore) #364

Closed
zachleat opened this issue Jan 8, 2019 · 3 comments
Closed
Labels
breaking-change This will have to be included with a major version as it breaks backwards compatibility. enhancement

Comments

@zachleat
Copy link
Member

zachleat commented Jan 8, 2019

Breaking change, but almost certainly not necessary.

While I don’t think it’s required to git to place this in your project root, it is the prevailing convention.

Note this on the GitHub docs: https://docs.github.com/en/github/getting-started-with-github/getting-started-with-git/ignoring-files#configuring-ignored-files-for-a-single-repository

You can create a .gitignore file in your repository's root directory to tell Git which files and directories to ignore when you make a commit.

Changed in #229 (comment)

@zachleat zachleat added this to the Next Major Version milestone Jan 8, 2019
@zachleat zachleat added the needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved. label Jan 8, 2019
@zachleat
Copy link
Member Author

zachleat commented Jan 8, 2019

This repository is now using lodash style issue management for enhancements. This means enhancement issues will now be closed instead of leaving them open.

View the enhancement backlog here. Don’t forget to upvote the top comment with 👍!

@zachleat zachleat closed this as completed Jan 8, 2019
@zachleat zachleat removed the needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved. label Nov 22, 2020
@zachleat zachleat reopened this Nov 22, 2020
@zachleat zachleat modified the milestones: Planning for Eleventy v1.0.0, Eleventy 1.0.0 Nov 22, 2020
@zachleat zachleat added the breaking-change This will have to be included with a major version as it breaks backwards compatibility. label Jun 13, 2021
@zachleat
Copy link
Member Author

Just for extra clarity, this means we look for ignores in these files in 1.0:

$ROOT/.gitignore
- $INPUT/.gitignore
$ROOT/.eleventyignore
$INPUT/.eleventyignore

zachleat added a commit to 11ty/11ty-website that referenced this issue Jun 13, 2021
@szegheo
Copy link

szegheo commented Feb 2, 2022

For me, this change has made some trouble after the upgrade to 1.0 but I can understand my use-case is not typical.

For my needs (technically identical microsites) I made a private wrapper package around 11ty and webpack with all my helpers, shortcodes, and a lot of custom stuff...

Because of this my $ROOT never matches $INPUT - for reason - and I cannot change this.
Since 1.0 in my $INPUT dir I MUST duplicate items in .eleventyignore because its .gitignore pair is ignored.

I can live with it, just wondering if some new API could bring back the old behavior or make it possible to manually add a .gitignore file? May I expect this feature to be added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will have to be included with a major version as it breaks backwards compatibility. enhancement
Projects
None yet
Development

No branches or pull requests

2 participants