-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renderTransforms
filter not rendering inputPathToUrl
transform plugin
#3320
Comments
You’re one day ahead of me here. Stay tuned! |
v2.0.0 of the RSS plugin has shipped which fixes this issue. Docs for this are shipping to: https://www.11ty.dev/docs/plugins/rss/ You can either use the Virtual Template approach (which solves this for you) or the updated sample feed templates: https://www.11ty.dev/docs/plugins/rss/#sample-feed-templates I’ve updated the template from your reproduction project below:
This new method uses the renderTransforms to apply the base url via the HTML plugin. This increases performance as we don’t need to run posthtml twice for each templates. Related: 11ty/eleventy-plugin-rss#38 |
|
Works great, thank you! |
Operating system
macOS Big Sur 11.5.2
Eleventy
3.0.0-alpha.12
Describe the bug
I'd been trying out the
inputPathToUrl
transform plugin on 3.0.0-alpha.10, but was ready to give up on it because it left a bunch of broken links in my RSS feed. Looking for a workaround led me to #3294, so I impatiently updated to the then-latest commit (16a0eeb) to see ifrenderTransforms
would help - and it did, which was awesome!Today I updated to 3.0.0-alpha.12 and my feed's links went back to pointing to
.md
and.njk
files, as if the filter weren't there. It looks like commit fd6ff40 is what broke it, but I haven't been able to troubleshoot past that. Still not working as of 168f441.Reproduction steps
See reproduction repo. Builds as expected using Eleventy commit 16a0eeb through 4640413. Beginning from commit fd6ff40 input path URLs are not transformed in
feed.njk
.Expected behavior
Expected
[home page](/index.md)
frompost.md
to render as<a href="https://example.com/">home page</a>
in_site/feed.xml
. Renders instead as<a href="https://example.com/index.md">home page</a>
Reproduction URL
https://github.com/cypressSap/11ty-rendertransforms-issue-reproduction
Screenshots
No response
The text was updated successfully, but these errors were encountered: