Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for globalThis inside of templates to reference the global scope #1919

Closed
zachleat opened this issue Aug 4, 2021 · 3 comments
Closed

Add support for globalThis inside of templates to reference the global scope #1919

zachleat opened this issue Aug 4, 2021 · 3 comments
Labels
enhancement needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved.

Comments

@zachleat
Copy link
Member

zachleat commented Aug 4, 2021

Could solve the problem of trying to reference top level globals with dashes in the name

#567 #1535

Moderate overlap with #874
Marginal overlap with #1060
Unconfirmed overlap with #1541
@zachleat
Copy link
Member Author

zachleat commented Aug 4, 2021 •
edited
Loading

https://node.green/ has globalThis support in Node at 12+ but for the record this would just be faking it for template-land vars

@zachleat zachleat mentioned this issue Aug 4, 2021
Closed
@zachleat zachleat added the needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved. label Aug 4, 2021
@zachleat
Copy link
Member Author

zachleat commented Aug 4, 2021

This repository is now using lodash style issue management for enhancements. This means enhancement issues will now be closed instead of leaving them open.

View the enhancement backlog here. Don’t forget to upvote the top comment with 👍!

@zachleat zachleat closed this as completed Aug 4, 2021
@zachleat zachleat mentioned this issue Aug 4, 2021
Closed
@zachleat
Copy link
Member Author

zachleat commented Aug 4, 2021

Could even use approaches in #567 like @edwardhorsford’s: #567 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zachleat