Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default change: dataTemplateEngine: false in Configuration Object #174

Closed
zachleat opened this issue Jul 14, 2018 · 9 comments
Closed

Default change: dataTemplateEngine: false in Configuration Object #174

zachleat opened this issue Jul 14, 2018 · 9 comments

Comments

@zachleat
Copy link
Member

For performance reasons.

This appears to be an underutilized feature and could be disabled by default. If you make use of data preprocessing, please chime in here!

@zachleat zachleat added enhancement needs-discussion Please leave your opinion! This request is open for feedback from devs. labels Jul 14, 2018
@zachleat zachleat added this to the Next Major Version milestone Jul 14, 2018
@zachleat zachleat added the needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved. label Aug 16, 2018
@zachleat
Copy link
Member Author

The other thing here is the #155 js data files will unlikely support any sort of preprocessing there.

@zachleat
Copy link
Member Author

This repository is now using lodash style issue management for enhancements. This means enhancement issues will now be closed instead of leaving them open.

The enhancement backlog can be found here: https://github.com/11ty/eleventy/issues?utf8=%E2%9C%93&q=label%3Aneeds-votes+sort%3Areactions-%2B1-desc+

Don’t forget to upvote the top comment with 👍!

@cfjedimaster
Copy link

I never knew it was a feature and if it's a performance hit, I'd be in favor of this. You could do the same with a .js file instead of .json, right? So if you can get the same result, I'd say go ahead.

@httpsterio
Copy link

Well, it's the first major version so breakage is allowed. I guess you can't really see how many users have this currently enabled, but we could check the submitted starter templates (as most start with those) and base on that?

If a significant amount of starters don't use it then it makes sense especially if there's a performance hit.

@zachleat
Copy link
Member Author

As clarification we would only turn this off by default. You could opt-back in very easily with config https://www.11ty.dev/docs/config/#default-template-engine-for-global-data-files

@zachleat zachleat modified the milestones: Planning for Eleventy v1.0.0, Eleventy 1.0.0 Sep 19, 2020
@zachleat zachleat removed needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved. needs-discussion Please leave your opinion! This request is open for feedback from devs. labels Sep 19, 2020
zachleat added a commit that referenced this issue Sep 19, 2020
@zachleat
Copy link
Member Author

Default change of "liquid" to false will ship with 1.0.

zachleat added a commit to 11ty/11ty-website that referenced this issue Sep 19, 2020
@zachleat
Copy link
Member Author

Docs added at 11ty/11ty-website@607f9d8

zachleat added a commit to 11ty/11ty-website that referenced this issue Sep 19, 2020
@zachleat
Copy link
Member Author

Deprecation warning added 11ty/11ty-website@0a3bf7c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants